Wireshark-bugs: [Wireshark-bugs] [Bug 8674] [PATCH] - GigE Vision GVCP dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 18 May 2013 22:13:21 +0000

Comment # 6 on bug 8674 from 
(In reply to comment #5)
> Created attachment 10791 [details]
> GVCP dissector patch
> 
> Thanks for the feedback. I've uploaded an updated patch file.

Your patch overwrites an existing dissector attempt for this protocol. Did you
look at the previous implementation?
Please also consider the comments put in bug 8673. I guess part of them will
applicable to this patch also.

> I have some functionality, register_custom_registers(), which is currently
> disabled in the patch. This is used to populate a table for decoding custom
> (vendor-specific) registers/fields. It currently only works for the first
> session because the data is allocated using the se_alloc() calls. I would
> like this to be persistent for the application runtime. If I use g_malloc()
> instead, where would I free this memory? Is there a callback for when
> Wireshark is closing? Is there a better way to do this?

Did you try using the wmem allocator with the wmem_epan_scope() pool?

You are receiving this mail because:
  • You are watching all bug changes.