Wireshark-bugs: [Wireshark-bugs] [Bug 8644] New Dissector - SEL RTAC (Real Time Automation Contr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 13 May 2013 15:36:06 +0000

Comment # 6 on bug 8644 from 
(In reply to comment #5)
> Hi Chris,
> 
> you will find below a few comments:
> - the header lacks the $Id$ SVN keyword
> - it might be better to move your dissector notes out of the Wireshark
> header template
> - you can remove the inclusion of packet-tcp.h and epan/packet-expert.h
> - change dissect_rtacser() to return the number of bytes consumed instead of
> a boolean. See new_dissector_t definition. The TRUE/FALSE return code is
> used for heuristic dissectors
> - If you request an official DLT/LINKTYPE value as suggested by Guy and add
> a preference allowing the user to select the sub dissector to be called
> (selfm, mbrtu, dnp3.udp, synphasor, ...), it would allow you to get rid of
> all the manual configuration in DLT_USER preferences

Thanks for the comments Guy and Pascal,

I had wondered about getting a custom DLT assigned to the dissector and how to
allow the user to manually select the payload protocol (since the payload is
never guaranteed, only the 12-byte header).  I do quite like the 'preferences'
idea to select the payload type and it would take away the 'manual
configuration' difficulty where a user could potentially mess things up.

I'll send a note to tcpdump-workers@lists.tcpdump.org with the header specs to
get an official DLT type assigned.

Chris

You are receiving this mail because:
  • You are watching all bug changes.