Wireshark-bugs: [Wireshark-bugs] [Bug 8629] bad tcp checksum not detected
Date: Mon, 06 May 2013 01:12:58 +0000

Comment # 8 on bug 8629 from
(In reply to comment #6)
> We already have a preference to disable TCP checksum validation.
> 
> Is there a compelling reason not to use that to handle TCP checksum
> offloading, i.e. if you have a capture with TCP checksums offloaded, so that
> (at least on outgoing packets) the TCP checksum doesn't reflect what went
> out on the wire, should that be handled by disabling TCP checksum offloading?

And we already have a preference to "Allow subdissector to reassemble TCP
streams".  Is there a compelling reason not to just use that to determine
whether or not to allow desegmentation to occur, irrespective of whether the
checksum is valid or not?  Today even in the case when the checksum is
incorrect but non-zero, Wireshark indicates that it might be because of
checksum offloading.  But if it is incorrect due to checksum offloading, then
the data is probably just fine and could very likely be successfully
desegmented if the option to so is enabled.


You are receiving this mail because:
  • You are watching all bug changes.