Wireshark-bugs: [Wireshark-bugs] [Bug 8600] SMTP dissector: improve AUTH handling (NTLM and elem
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 03 May 2013 13:14:26 +0000

Comment # 21 on bug 8600 from 
(In reply to comment #20)
> Comment on attachment 10708 [details]
> fix for auth plain decode
> 
> Is it dissected incorrectly with length_pass, or is it just an extra
> calculation?  If its the latter, I don't see the harm in leaving it.

I used length_pass to get the size of the password string only for debugging.
For proto_tree_add_string we need a_linelen and not length_pass. Otherwise the
packet bytes are marked wrong.

Your're right, it won't do any harm in leaving the calculation of length_pass
in.

Thanks for your checking.

You are receiving this mail because:
  • You are watching all bug changes.