Wireshark-bugs: [Wireshark-bugs] [Bug 8613] packet-ieee80211.c enhancements for Hotspot 2.0, WNM
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 02 May 2013 10:49:14 +0000

Comment # 46 on bug 8613 from 
(In reply to comment #45)
> (In reply to comment #44)
> I thinks, about this lign : 
> +    ssid = proto_tree_add_text(tree, tvb, offset, 2 + len, "SSID: %s", str);
> May be replace by proto_tree_add_item...

That text entry is just a title line for the subtree and I don't see any point
in making that proto_tree_add_item since the actual data field is added as an
item within this tree and as such, is available for display filter.

> (I thinks, Michael don't see the proto_tree_add_item after with only the
> SSID)

I'm assuming this was the reason and the patch does not need a change. The
proto_tree_add_item for hf_ieee80211_tag_ssid does indeed include that SSID
string that is also printed out with add_text for convenience in the UI.
Anyway, I do not change the review status for the attachment while waiting for
this to be confirmed.

You are receiving this mail because:
  • You are watching all bug changes.