Wireshark-bugs: [Wireshark-bugs] [Bug 7060] Global variables - Buildbot crash output: fuzz-2012-
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 02 May 2013 00:14:28 +0000

Comment # 12 on bug 7060 from 
(In reply to comment #11)
> I seem to remember attempting to do that
> to fix another problem, but the simple solution didn't work; I forget why. 
> (Not that this shouldn't be done - Global Variables Considered Harmful - but
> that we need to be careful when we do so.  Maybe I should try one of my big
> regression tests between the code without this change and the code with it.)

Do you want me to do a a few more and provide a (non-committed) patch?  My
criteria would be

1. Dissector doesn't otherwise use private_data member of asn1_ctx_t
2. global variable must only be used in a ber_sequence_t "grouping"

You are receiving this mail because:
  • You are watching all bug changes.