Wireshark-bugs: [Wireshark-bugs] [Bug 8600] SMTP dissector: improve AUTH handling (NTLM and elem
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 01 May 2013 00:46:01 +0000

Comment # 11 on bug 8600 from 
(In reply to comment #10)
> Created attachment 10663 [details]
> AUTH PLAIN decode username and password
> 
> As far as I can see epan_base64_decode return the length without the
> terminating NULL. The decoded string is terminated by NULL. Lenght of strlen
> is without terminating NULL.
> So I think the checks should be safe and not off-by-one.

Yup. I don't seem to be able to accurately articulate the behaviour of that
function for some reason...

> I fixed the col_append_sep_fstr calls.

Looks great. One final question: the two main blocks you're adding look very
similar at first glance. Does it make sense to factor them out into a small
function?

Thanks,
Evan

You are receiving this mail because:
  • You are watching all bug changes.