Wireshark-bugs: [Wireshark-bugs] [Bug 7471] "Bad" UAT entry can't be edited/removed via the Wire
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 21 Apr 2013 14:21:44 +0000

Comment # 7 on bug 7471 from 
In general I like the approach. A few misc questions:

- any reason to use g_array_append_vals instead of just g_array_append_val?

- the use of gboolean* valid is entirely redundant, I think

- the call to UAT_UPDATE(uat) got removed from uat_remove_record_idx, was this
intentional?

My gut feeling re. backporting is no, but if you want to land this before 1.10
branches tomorrow that might be a good idea.

Cheers,
Evan

You are receiving this mail because:
  • You are watching all bug changes.