Wireshark-bugs: [Wireshark-bugs] [Bug 8562] New dissector for ISO 10747 Interdomain Routeing Pro
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 07 Apr 2013 17:20:03 +0000

Comment # 14 on bug 8562 from 
I've played some more with the dissector

- for the subtrees like IPDU UPDATE, Path Attributes, ...
  please highlight the corresponding bytes

- please use hf items of type FT_STRING instead of proto_tree_add_text()

- set ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN for FT_UINTxx, don't set ENC_NA
  probably, your protocol is all big endian

- there's no need for the check around col_append_fstr()

- data_length = tvb_length_remaining(tvb, offset);

this function returns gint, don't assign this to a guint variable or we'll get
a large value for -1, causing a potential overflow


Best regards,
Martin

You are receiving this mail because:
  • You are watching all bug changes.