Wireshark-bugs: [Wireshark-bugs] [Bug 8446] Wifi details are not stored in the Decryption Key Ma
Comment # 24
on bug 8446
from Alexis La Goutte
(In reply to comment #23)
> Created attachment 10547 [details]
> AirPcap support with no keys
>
> Alexis,
>
> The attached patch fixes the issue mentioned in comment #21, but I can't
> duplicate the "assertion" in comment #22, so I'm holding off committing
> until then. Can provide more datails on that? I assumed it happened when
> launching the Decryption Key dialog with either no 80211_keys file or with
> 80211_keys file. Both work for me (on Windows XP 32-bit)
Hi Michael Mann,
Your patch work (add 80211_keys when it is not present) in Windows
But don't compile my Ubuntu Box :
airpcap_loader.c: In function ‘set_wep_key’:
airpcap_loader.c:267:13: erreur: passing argument 2 of ‘uat_load’ from
incompatible pointer type [-Werror]
./epan/uat.h:275:10: note: expected ‘const char **’ but argument is of type
‘char **’
cc1: all warnings being treated as errors
If I add const to err :
@@ -249,7 +249,7 @@ set_wep_key(pref_t *pref, gpointer ud _U_)
keys_cb_data_t* user_data;
uat_t *uat;
gint i;
- char* err = NULL;
+ const char* err = NULL;
I get a another error :
airpcap_loader.c: In function ‘set_wep_key’:
airpcap_loader.c:285:9: erreur: passing argument 2 of ‘uat_save’ from
incompatible pointer type [-Werror]
./epan/uat-int.h:94:10: note: expected ‘char **’ but argument is of type ‘const
char **’
cc1: all warnings being treated as errors
if i add a another err(2) variable, it works.
@@ -249,7 +249,8 @@ set_wep_key(pref_t *pref, gpointer ud _U_)
keys_cb_data_t* user_data;
uat_t *uat;
gint i;
- char* err = NULL;
+ const char* err = NULL;
+ char* err2 = NULL;
uat_wep_key_record_t uat_key;
decryption_key_t* new_key;
@@ -282,8 +283,8 @@ set_wep_key(pref_t *pref, gpointer ud _U_)
uat_add_record(uat, &uat_key);
}
- uat_save(uat, &err);
- if (err != NULL)
+ uat_save(uat, &err2);
+ if (err2 != NULL)
return 1;
}
May be the better solution will be to change uat_save function to pass a const
char ** ? (but the API/ABI will be broken ? this bug will be backported to
1.8.x)
About Gtk-CRITICAL error, i have only this error in my Ubuntu box when there is
no 80211_keys file.
You are receiving this mail because:
- You are watching all bug changes.
