Wireshark-bugs: [Wireshark-bugs] [Bug 8562] New dissector for ISO 10747 Interdomain Routeing Pro
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 05 Apr 2013 11:24:29 +0000

changed bug 8562

What Removed Added
Status UNCONFIRMED IN_PROGRESS
CC   wireshark@kaiser.cx
Ever confirmed   1

Comment # 2 on bug 8562 from 
Hi,

some quick comments

- typo: routeing -> routing

- we always HAVE_CONFIG_H

- please add the new dissector to epan/dissectors/Makefile.common
  and epan/CMakeLists.txt

- please try to use filterable items where possible instead of using
  proto_tree_add_text(), e.g. for idrp version, hold time, etc

- formatting is a bit strange, please add editor modelines

- for the strings, you can define an FT_STRING hf variable instead of using
proto_tree_add_text() and tvb_bytes_to_str()
see hf_dvbci_cis_tpll_v1_info_manuf in packet-dvbci.c for an example

Regards,

Martin

You are receiving this mail because:
  • You are watching all bug changes.