Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8465] nfs-block:decode GETDEVINFO error when using pnfs-block

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 9 on bug 8465 from fanchaoting

(In reply to comment #7)
> (In reply to comment #1)
> > Created attachment 10239 [details]
> > nfs:decode GETDEVINFO error when	 using pnfs-block
> 
> Hi,
> 
> thanks a lot for the patch. It does not apply cleanly on the current trunk
> but it is quite easy to fix.
> 
> I have a few questions / comments as I'm not familiar with NFS:
> 1/ please use guint32 instead of guint as you are fetching data with
> tvb_get_ntohl()
> 2/ Why is there an offset += 4 in the BLOCK_VOLUME_SIMPLE? Isn't it instead
> the number of pnfs_block_sig_component4 present in that volume (from 1 to
> 16)? If yes, the code should do a loop on the number of components and
> possibly add an expert info waning/error if the value is > 16
> (PNFS_BLOCK_MAX_SIG_COMP)
> 3/ would it be possible to add the dissection code for BLOCK_VOLUME_CONCAT?
> 
> Regards,
> Pascal.

i'm sorry for replying later.
1/ i use guint32 instead of guint and change the patch later.

2/ i see the pnfs kernel,and now only support one component,i thinks the kernel
maybe support more than one component and i'll change the patch.

3/ the pnfs kernel didn't support BLOCK_VOLUME_CONCAT now, so i didn't add the
dissection code for BLOCK_VOLUME_CONCAT. it maybe support BLOCK_VOLUME_CONCAT
in the further.

thanks

---

      You are receiving this mail because:

• You are watching all bug changes.