Wireshark-bugs: [Wireshark-bugs] [Bug 8522] Add heuristic to dissect DVB-S2 over ethernet
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 25 Mar 2013 14:11:48 +0000

changed bug 8522

What Removed Added
Status INCOMPLETE CONFIRMED

Comment # 4 on bug 8522 from 
(In reply to comment #3)
> Evan,
> 
> Thank you for your comments.
> 
> (In reply to comment #1)
> > I don't think this will quite work the way you expect? The ethernet
> > dissector shouldn't be passing the ethernet header in the tvb to
> > dissect_dvb_s2_modeadapt_eth, so there should be no need to skip it.
> 
> I first tried to directly use the dissect_dvb_s2_modeadapt, and was
> surprised to find that the ethernet header was also passed to the function,
> which is why I added the skip.

I would think that's a bug in the Ethernet dissector, but I will have to check.

> > Skipping it the way you've done also (I think) makes the function return an
> > incorrect offset? You would have to add ETHERNET_HEADER_SIZE to the result
> > of dissect_dvb_s2_modeadapt.
> 
> How can I check this point? Currently, the dissector does not show a
> "malformed packet" message.

Not sure. Hopefully it ends up being unnecessary.

Thanks for the sample capture.

Evan

You are receiving this mail because:
  • You are watching all bug changes.