Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8505] openSAFETY: New reassemble functionality, as well as minor bugfixes

[bugzilla-daemon@xxxxxxxxxxxxx]

Evan Huus changed bug 8505

What	Removed	Added
Status	INCOMPLETE	CONFIRMED

Comment # 14 on bug 8505 from Evan Huus

Thanks for the protocol summary, that makes a lot of things make sense.

I think either I am confused about what your code is doing, or you are confused
about how the tvb functions work.

Right now, you do:
    ssdoIndex = ((guint16)(bytes[1] << 8) + bytes[0]);
where 'bytes' is copied from the start of the tvb. Would you not get exactly
the same result by doing
    ssdoIndex = tvb_get_ntohs(tvb, 0);

And similarly, where you do:
    sodLength = read_lowhigh_order(bytes, 3);
would you not get exactly the same value from
    sodLength = tvb_get_ntohl(tvb, 3);

I don't see the need for fancy macros or offset calculations beyond the ones
you've already  got. If I understand correctly, every call to
read_lowhigh_order can be replaced as-is with a call to tvb_get_ntohl simply by
replacing 'bytes' with 'tvb'.

Or am I missing some obvious extra manipulation you're doing?

Evan

---

      You are receiving this mail because:

• You are watching all bug changes.