Wireshark-bugs: [Wireshark-bugs] [Bug 8523] Bluetooth: Fix capture interfaces
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 25 Mar 2013 11:16:12 +0000

changed bug 8523

What Removed Added
Attachment #10459 Flags   review_for_checkin?

Comment # 4 on bug 8523 from 
Created attachment 10459 [details]
[PATCH] Bluetooth: Fix Bluetooth capture interfaces

(In reply to comment #3)
> Comment on attachment 10457 [details]
> [PATCH] Bluetooth: Fix Bluetooth capture interfaces
> 
> If strlen(name) + 1 > ARGV_NUMBER_LEN, this will cause an array bounds
> error, given that sdlt is defined as
> 
>     char sdlt[ARGV_NUMBER_LEN];
> 
> Given that the result of linktype_val_to_name() is a name, not a number, the
> use of ARGV_NUMBER_LEN as the size of sdlt is bogus.
> 
> Given that sync_pipe_add_arg() makes a copy of the argument, there does not
> appear to be any reason not to just pass
> linktype_val_to_name(interface_opts.linktype) as the last argument to it,
> and get rid of sdlt entirely.

That's right. Thanks. New patch attached.

You are receiving this mail because:
  • You are watching all bug changes.