Wireshark-bugs: [Wireshark-bugs] [Bug 8517] Misuse of *_idx value string API
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 24 Mar 2013 12:21:35 +0000

Comment # 1 on bug 8517 from 
Pascal fixed the gsm_a_dtap instance in r48520.

The only other instance I know of is packet-gsm_map-template.c line 1916 (and
the corresponding generated dissector). The index is stored unconditionally in
an unsigned variable which is then used unconditionally in
ui/gtk/gsm_map_stat.c around line 306.

Tangentially, in several places the use of the (more complicated and unsafe)
function match_strval_idx is unnecessary (though this is much less a bug and
more a room for simplification). In packet-ansi_801.c:1159 and
packet-ansi_a.c:3384, for example, it can be trivially replaced with
val_to_str_const. There are probably other cases of this as well, though I have
not checked.

You are receiving this mail because:
  • You are watching all bug changes.