Wireshark-bugs: [Wireshark-bugs] [Bug 8465] nfs-block:decode GETDEVINFO error when using pnfs-bl
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 23 Mar 2013 12:00:10 +0000

changed bug 8465

What Removed Added
CC   pascal.quantin@gmail.com

Comment # 7 on bug 8465 from 
(In reply to comment #1)
> Created attachment 10239 [details]
> nfs:decode GETDEVINFO error when	 using pnfs-block

Hi,

thanks a lot for the patch. It does not apply cleanly on the current trunk but
it is quite easy to fix.

I have a few questions / comments as I'm not familiar with NFS:
1/ please use guint32 instead of guint as you are fetching data with
tvb_get_ntohl()
2/ Why is there an offset += 4 in the BLOCK_VOLUME_SIMPLE? Isn't it instead the
number of pnfs_block_sig_component4 present in that volume (from 1 to 16)? If
yes, the code should do a loop on the number of components and possibly add an
expert info waning/error if the value is > 16 (PNFS_BLOCK_MAX_SIG_COMP)
3/ would it be possible to add the dissection code for BLOCK_VOLUME_CONCAT?

Regards,
Pascal.

You are receiving this mail because:
  • You are watching all bug changes.