Wireshark-bugs: [Wireshark-bugs] [Bug 8515] New: Global variables in X.400 P1 dissector consider
| Bug ID |
8515
|
| Summary |
Global variables in X.400 P1 dissector considered harmful
|
| Classification |
Unclassified
|
| Product |
Wireshark
|
| Version |
SVN
|
| Hardware |
All
|
| OS |
All
|
| Status |
UNCONFIRMED
|
| Severity |
Normal
|
| Priority |
Low
|
| Component |
Dissection engine (libwireshark)
|
| Assignee |
bugzilla-admin@wireshark.org
|
| Reporter |
guy@alum.mit.edu
|
Created attachment 10438 [details]
Capture that causes crashes
Build Information:
wireshark 1.9.1 (SVN Rev 48345 from /trunk)
Copyright 1998-2013 Gerald Combs <gerald@wireshark.org> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Compiled (64-bit) with GTK+ 2.24.10, with Cairo 1.12.2, with Pango 1.30.0, with
GLib 2.32.3, with libpcap, with libz 1.2.5, without POSIX capabilities, without
libnl, with SMI 0.4.8, without c-ares, without ADNS, with Lua 5.1, without
Python, with GnuTLS 2.12.19, with Gcrypt 1.5.0, with MIT Kerberos, with GeoIP,
with PortAudio V19-devel (built Feb 1 2013 19:03:47), with AirPcap.
Running on Mac OS X 10.8.2, build 12C3012 (Darwin 12.2.1), with locale
en_US.UTF-8, with libpcap version 1.1.1, with libz 1.2.5, GnuTLS 2.12.19,
Gcrypt
1.5.0, without AirPcap.
Intel(R) Core(TM) i7-3820QM CPU @ 2.70GHz
Built using llvm-gcc 4.2.1 (Based on Apple Inc. build 5658) (LLVM build
2336.11.00).
--
The P1 dissector has a bunch of global variables it uses to pass information
between routines.
Those variables are never reset, and there are some code paths where if they've
been set while dissecting packet N, those variables will cause problems,
including crashes, when dissecting packet M > N, as, for example, some pointers
will have been set to point to protocol tree items, and some Booleans will have
been set to tell routines to use those pointers, in the dissection of packet N,
and the dissection of packet M will try to use those no-longer-valid pointers.
This causes crashes with the 9801-packet-per.pcap file in the Wireshark
menagerie; it's probably attached to some other bug, but I'll attach it here.
You are receiving this mail because:
- You are watching all bug changes.
