Wireshark-bugs: [Wireshark-bugs] [Bug 8371] Patch to open reference packet in new window
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 21 Mar 2013 15:29:46 +0000

changed bug 8371

What Removed Added
Attachment #10412 is patch   1
Attachment #10412 mime type application/octet-stream text/plain
Attachment #10412 Flags review_for_checkin? review_for_checkin+

Comment # 6 on bug 8371 from 
Comment on attachment 10412 [details]
patch to open reference packet in new window (fixed tabs and
[-Werror=maybe-uninitialized] error)

Thanks for the updated patch, I've committed most of it in r48451.

The part I didn't commit was the Ctrl-click change, because I couldn't get that
to work. I think perhaps you should be checking it as a mask (with logical &)
instead of doing a direct comparison, but even when I made that change locally
it worked inconsistently. I'm not a GTK expert, so I'm not sure what's going
on.

Thoughts?

You are receiving this mail because:
  • You are watching all bug changes.