Wireshark-bugs: [Wireshark-bugs] [Bug 8503] Add USBPcap support
Date: Thu, 21 Mar 2013 11:05:04 +0000

Comment # 4 on bug 8503 from
(In reply to comment #3)
> Hi Pascal,
> 
> Thanks for taking a look at this patch. I have used the tvb_memcpy() for the
> same reason the dissect_linux_usb_pseudo_header() does use it: the protocol
> is host-endian (for x86 and x64 it's little-endian).

Thanks for the info. I now realize I missed the nice comment you put at the
beginning of the dissect_win32_usb_pseudo_header() function. Sorry about that.

> The protocol is not fixed yet though. Do you think enforcing little-endian
> at the protocol level would be an advantage?

It would avoid stupid comments like mine ;)


You are receiving this mail because:
  • You are watching all bug changes.