Wireshark-bugs: [Wireshark-bugs] [Bug 8505] openSAFETY: New reassemble functionality, as well as
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 21 Mar 2013 08:05:07 +0000

Comment # 5 on bug 8505 from 
(In reply to comment #3)
> The indentation in the patch is inconsistent with the existing dissector.
> Adding the correct modelines to the bottom of the file may help:
> https://www.wireshark.org/tools/modelines.html
> 
> Also, please attach the capture file(s) you used for fuzz-testing.

Changed the patch to correctify the modelines.

The following changes have been made additional to the original post:

 - Corrected identations throughout the dissector
 - Removed separate SNMT parameter timestamp field and changed to generic
 - Added generic SOD parameter timestamp field
 - Added specific dissection for 0x1018/0x6 and 0x7 where they are needed

You are receiving this mail because:
  • You are watching all bug changes.