Wireshark-bugs: [Wireshark-bugs] [Bug 8504] Problem dissecting RTP-MIDI Chapter X journals
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 20 Mar 2013 17:28:03 +0000

Comment # 3 on bug 8504 from 
I think my previous analysis isn't quite correct.  The test would need to be
">=" if a Chapter X section was present, and ">" if no Chapter X section was
present.

As far as I can tell, each of the functions which dissect the individual
chapters of the system journal checks for itself that it can safely read bytes
from the packet.  If this is the case, then it seems to me that this "sanity
check" is in fact redundant and can safely be removed; the check right at the
end of decode_system_journal() will catch any packets in which the length of
the system journal is incorrectly declared, which is all that's necessary.

You are receiving this mail because:
  • You are watching all bug changes.