Wireshark-bugs: [Wireshark-bugs] [Bug 8502] Allow reassemble for sequences, where sequence does
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 20 Mar 2013 10:36:14 +0000

Comment # 1 on bug 8502 from 
I like the idea, some comments though.
It seems as though you use 'frame number' and 'fragment number'
interchangeably, I think you meant to settle on fragment number.
You use camelBack for your variables, while the rest of the code uses
underscores. Please keep it consistent that way.
You could also add to reassemble_test.c
What happens if frag_number is smaller than the offset? You then get an
overlap?

You are receiving this mail because:
  • You are watching all bug changes.