Wireshark-bugs: [Wireshark-bugs] [Bug 8467] Need functions to mirror val_to_str
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 19 Mar 2013 11:52:43 +0000

Comment # 6 on bug 8467 from 
(In reply to comment #2)
> The sip dissector appears to do its own thing with hash tables at a few
> spots, so I'm not sure how applicable this would be.

Sorry I didn't mean to replace the current SIP ones, just pointing that out as
an example that for some protocols sometimes string values are compared
case-sensitive, sometimes case-insensitive.  So if you're looking to add a
generic set of table functions for string-to-val, you might want both types.
(SIP isn't the only one with this behavior either: HTTP, MGCP, RTSP, and SMTP
do too) 

As for whether to do hash-tables or not, it's not worth the hassle.  It makes
sense for SIP because its messages have a lot of headers in them, and a lot of
possible header names to match each of them against. (currently 106 header
names, and that will likely grow)  But for protocols that only match against a
small table size, it wouldn't be worth it and might even be slower to do a hash
lookup.

You are receiving this mail because:
  • You are watching all bug changes.