Wireshark-bugs: [Wireshark-bugs] [Bug 8421] RFC5908 is not implemented
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 18 Mar 2013 22:14:11 +0000

Comment # 4 on bug 8421 from 
Very nice work.

Without a sample it's hard to tell, but I think this has a looping issue?

Both optlen and temp_optlen are unsigned, so subtracting them will always
result in >= 0. I think while (optlen > temp_optlen) would be better?

Also, if subopt_len is crafted to (MAX_UINT16 - 4) then temp_optlen never is
invariant and the loop runs forever. This is perhaps another case of bug #3290
though, I haven't checked how subopt_len is used.

You are receiving this mail because:
  • You are watching all bug changes.