Wireshark-bugs: [Wireshark-bugs] [Bug 8489] Dissector for NASDAQ's SoupBinTCP 3.0 protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 17 Mar 2013 21:37:19 +0000

Comment # 1 on bug 8489 from 
Quick review:
1) CMakeLists.txt has the wrong filename added
2) You could use the PINFO_FD_VISITED() macro
3) Never use g_assert in a dissector, use DISSECTOR_ASSERT() macro instead
4) never wrap try_conversation_dissector() or dissector_try_heuristic() in an
'if (tree)' conditional

You are receiving this mail because:
  • You are watching all bug changes.