Wireshark-bugs: [Wireshark-bugs] [Bug 8431] New Dissector Patch - USB PTP / MTP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 17 Mar 2013 17:33:00 +0000

Comment # 28 on bug 8431 from 
A few more points (I apologize, I still haven't had time to do a full review):

- Your changes to test-fuzzed-cap.sh accidentally made it into your main patch,
which makes it a bit difficult to merge.

- The fact that the auto-generated tables have to be hand-merged is a bit of a
pain. Is there a way to split the auto-generated and manual values (either into
two tables, or into two cleanly-divided halves of the one table) so this isn't
necessary?

- Can you explain the value_string_masked a bit? I think I understand it, but
it's not apparently documented in the code. If I understand it correctly, it
should probably be landed in epan/value_string.[ch] directly so other code can
potentially use it. This might end up tying up with bug #8467 in some way?

- The recent packet-usb changes so that the tables are auto-updated each week
may cause problems merging your patch? I haven't tried.

You are receiving this mail because:
  • You are watching all bug changes.