Wireshark-bugs: [Wireshark-bugs] [Bug 7530] Memory leak of frame_data->opt_comment when closing
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 13 Mar 2013 16:34:53 +0000

Comment # 9 on bug 7530 from 
(In reply to comment #8)
> Hmm come to think of it what data needs to be recreated in frame data?
> Data in the packet list and columns needs to be recreated as dissection may
> change with change of preferences.

Looking at the code of rescan_packets, all it does is manually reset a single
flag and call frame_data_cleanup() in order to free the per-protocol frame
data.

I'm thinking we should just create a frame_data_reset which:
- clears the visited flag
- frees the per-protocol frame data
rescan_packets should call that instead.

Then frame_data_cleanup can free opt_comment the way it ought to. I will attach
a patch shortly that I think ought to be correct.

You are receiving this mail because:
  • You are watching all bug changes.