Wireshark-bugs: [Wireshark-bugs] [Bug 7530] Memory leak of proto data GSList and frame comment w
Comment # 3
on bug 7530
from Evan Huus
(In reply to comment #2)
> I think Jakub suggested to store the comments in a hashtable and just use a
> flag in frame data whether there is a comment or not (to save memory). We
> should perhaps differentiate between saved comments which can be read back
> from file and comments added during the session which would have to be
> preserved in memory. Re reading a file a check in the "new unsaved comments"
> hastable could be done per frame - capacity loss? use a flag for empty table?
>
> Or a more brutal approach "Unsaved comments exists - please (re)save your
> file"
> Regards
> Anders
This makes sense to me, assuming there is a fast(ish) way to reread the comment
on a specific frame from file?
To be sure I am following correctly:
Two boolean flags in frame data - one indicating 'saved comment' one indicating
'unsaved comment' (they might both be set if the user has modified a saved
comment but not yet resaved). Saved comments are not stored in memory (they can
be reread from file). Unsaved comments are stored in a hash table mapping frame
number to string. On file close, we simply check if the hash table is empty
using g_hash_table_size.
You are receiving this mail because:
- You are watching all bug changes.
