Wireshark-bugs: [Wireshark-bugs] [Bug 7530] Memory leak of proto data GSList and frame comment w
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 11 Mar 2013 16:44:58 +0000

changed bug 7530

What Removed Added
CC   eapache@gmail.com

Comment # 1 on bug 7530 from 
As of r48030, free_frame_data_sequence() correctly calls frame_data_cleanup()
for every frame it owns.

free_frame_data_sequence() is already called by cf_reset_state(), which is
called by cf_close().

We do not, however, free fdata->opt_comment in frame_data_cleanup because, as
indicated by the comment in that function: "frame_data_cleanup() is called when
redissecting (rescan_packets()), which might be triggered by lot of things,
like: preferences change, setting manual address resolve, etc.. (grep by
redissect_packets). fdata->opt_comment can be set by user, which we must not
discard when redissecting."

Not sure the best way to scope that.

You are receiving this mail because:
  • You are watching all bug changes.