Wireshark-bugs: [Wireshark-bugs] [Bug 8456] Buildbot crash output: fuzz-2013-03-10-3098.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 10 Mar 2013 21:33:52 +0000

Comment # 6 on bug 8456 from 
(In reply to comment #5)
> > I believe this could be fixed by having val_to_str use pinfo-scoped wmem
> > memory? It would fix tshark at least, not sure if Wireshark requires an even
> > larger scope?
> 
> Looking at packet-rpki-rtr.c code setting COL_INFO is done in while() loop,
> so probably col_append_sep_str() is much better than col_set_str().
> [and it'll fix this bug]
> 
> If you want to know my opinion about bug #3984, I think we should always
> make a copy of buffer passed in col_set_str() and forget about it.
> [But I never profile it].

Which would make col_set_str() exactly equivalent to col_add_str()? I'm
perfectly happy just getting rid of col_set_str() entirely and replacing all
calls to it with calls to col_add_str().

"The First Rule of Program Optimization: Don't do it. The Second Rule of
Program Optimization (for experts only!): Don't do it yet." — Michael A.
Jackson

You are receiving this mail because:
  • You are watching all bug changes.