Wireshark-bugs: [Wireshark-bugs] [Bug 8424] Extend RTP dissector with ED-137 extension
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 04 Mar 2013 20:37:34 +0000

Comment # 9 on bug 8424 from 
Thank you for your patience.

> - My version of GCC complains in one spot:
> packet-rtp.c: In function 'dissect_rtp_hdr_ext_ed137':
> packet-rtp.c:1862:15: error: variable 'ft_len' set but not used
> [-Werror=unused-but-set-variable]

Corrected

> - You should probably use tvb_reported_length instead of tvb_length, in order
> to correctly handle captures that were truncated.

Corrected

> - The brace positioning around your col_append_fstr() calls is a bit odd. Is
> there a reason for that?

I'm not sure what you mean. I corrected placement of braces. But I prefer to
use braces after 'if' even there is only one command after and it don't have to
be used.

May I ask an advice?
When you check ED137A sample file and look to packet no 9, you would see that
wireshark shows that this RTP packet is malformed. It is because it has no RTP
payload, only header. But ED137 packet can has no payload and packet is
correct.
RTP dissector throws exception to show it.
I want to correct it but I'm not able to find out where exception is thrown.
May you point me to way how to find it?

You are receiving this mail because:
  • You are watching all bug changes.