Wireshark-bugs: [Wireshark-bugs] [Bug 8408] add configuration fields for Memcache TCP and UDP po
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 03 Mar 2013 20:44:11 +0000

changed bug 8408

What Removed Added
Status UNCONFIRMED IN_PROGRESS
CC   pascal.quantin@gmail.com
Ever confirmed   1

Comment # 2 on bug 8408 from 
Hi Josef,

I had a quick look and you will find below a few comments:

- It's better to leave the create_dissector_handle calls in
proto_reg_handoff_memcache() rather than in proto_register_memcache(). You can
check whether the dissector has been initialized or not thanks to a static
variable (see README.developer chapter 1.2 for an example).

- No need to make orig_memcache_tcp/udp_port_range a global. Let it static in
proto_reg_handoff_memcache and free it when the initialization variable
suggested in the previous comment is set to TRUE (see packet-dmp.c for an
example).

- The initialization of memcache_tcp/udp_port_range with range_empty() seems
useless as it is initialized with range_convert_str().

You are receiving this mail because:
  • You are watching all bug changes.