Guy Harris
changed
bug 8382
| What |
Removed |
Added |
| Component |
TShark
|
Dissection engine (libwireshark)
|
Comment # 33
on bug 8382
from Guy Harris
(In reply to comment #18)
> Created attachment 10149 [details]
> Remove format_text
>
> Why is the format_text even necessary? Can we just provide the string
> returned from tvb_get_ephemeral_unicode_string() directly? We already know
> the value is going to be bogus/garbage because length > packet length.
> expert_info may be overkill.
format_text()'s job is to convert character strings using 8-bit-octet encodings
(such as UTF-8) into something "printable". Currently, it just cheats and shows
all octets with the 8th bit set, and non-printable ASCII, as C-style escape
sequences, but it should do something better (where there may be more than one
flavor of "something better" as per my comment - C string, or use REPLACEMENT
CHARACTER etc.).
You are receiving this mail because:
- You are watching all bug changes.
