Wireshark-bugs: [Wireshark-bugs] [Bug 8424] Extend RTP dissector with ED-137 extension
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 01 Mar 2013 22:37:38 +0000

changed bug 8424

What Removed Added
Status UNCONFIRMED INCOMPLETE
CC   eapache@gmail.com
Ever confirmed   1

Comment # 1 on bug 8424 from 
Hi Jiri, thanks for the patch. If you could attach a short capture with sample
traffic (for testing), that would be appreciated.

A few notes on your patch:

- The indentation is an inconsistent mix of spaces and tabs. This doesn't
affect the correctness, but it does make it harder to read (and thus for
someone to review).

- You use proto_tree_add_uint in a lot of places where proto_tree_add_item
would probably be preferred

- Wireshark currently doesn't compile everywhere with support for C++ comments
(//). Please replace them with C comments (/* */). Also, please try and comment
in English where possible.

Cheers,
Evan

You are receiving this mail because:
  • You are watching all bug changes.