Wireshark-bugs: [Wireshark-bugs] [Bug 8379] HPFEEDS protocol : honeypot protocol feeds support a
Date: Fri, 22 Feb 2013 12:27:29 +0000

changed bug 8379

What Removed Added
Attachment #10089 Flags   review_for_checkin-

Comment # 1 on bug 8379 from
Comment on attachment 10089 [details]
packet-hpfeeds patch

Quick review comments:
* never advance offset based on type size, always use a defined or absolute
size
* never encapsulate column functionality within 'if (tree' constructs.
* you may want to introduce a default case for opcode, in which you assume the
fist byte being the length of the PDU.
* properly indent (using tab) in Makefile.common.


You are receiving this mail because:
  • You are watching all bug changes.