Wireshark-bugs: [Wireshark-bugs] [Bug 8313] new dissector for SML protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 15 Feb 2013 03:29:45 +0000

Comment # 10 on bug 8313 from 
Hi Alex, it's looking really good. Just one minor thing (which is mostly my
fault for not explaining well).

The ENC_ values should be one of ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN for any
field that is more than one byte in length (and thus has an endianness to worry
about). ENC_NA is available for single-byte values (that don't have an
endianness) and for fields like FT_BYTES which designate an arbitrary-length
array of bytes with no particular interpretation (and thus no particular
endianness). There are also other encoding values for strings (ASCII vs UTF-8
etc) and other specific types, but I don't think any of them apply to SML. For
more details see doc/README.developer around line 2357.

Other than this I believe it's ready to check in.

Cheers,
Evan

You are receiving this mail because:
  • You are watching all bug changes.