Wireshark-bugs: [Wireshark-bugs] [Bug 8239] Dissector for Microsofts SSTP VPN Protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 20 Jan 2013 20:54:43 +0000

Comment # 15 on bug 8239 from 
(In reply to comment #12)
> Created attachment 9848 [details]
> sstp dissector patch
> 
> Thanks Alexis and Evan for your review :)
> 
> i fixed everything mentioned in comment #8, comment #9, comment #10 except:
> 
> > the chechAPIs script reports also a warning :
> > Warning: epan/dissectors/packet-sstp.c does not have an SVN Id tag.
> according to 3.11
> (https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcAdd.html):
> """
> This action is only possible/allowed by the Wireshark core developers who
> have write access to the Subversion repository. It is put in here to have
> all information in one place. """
> 


(The Developer's guide is not quite right. The patch submiiter can actually do
the first two steps (include the boilerplate & $Id$ in the source file patch).. 

I'll fix the Guide ....

You are receiving this mail because:
  • You are watching all bug changes.