Wireshark-bugs: [Wireshark-bugs] [Bug 8089] New Dissector - SEL (Schweitzer Engineering Laborato
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 15 Jan 2013 21:26:54 +0000

Comment # 31 on bug 8089 from 
(In reply to comment #29)
> (In reply to comment #28)
> > Some minor issues:
> > 
> > 1. I don't see much point to the #defines that just map to value_string
> > values.  Will they eventually be used in the code (via switch statements)? 
> > All but the function codes should just have the numeric value right in the
> > value_string.
> 
> Stylistically I would tend to disagree - even if they're only used in the
> one place I think the #defines are a good thing for readability/maintenance.
> Regardless, the dissector isn't complete yet (there are a few other things
> that aren't really used at the moment either) so they may end up used
> eventaully.

(A bit late but): +1.

You are receiving this mail because:
  • You are watching all bug changes.