Wireshark-bugs: [Wireshark-bugs] [Bug 8089] New Dissector - SEL (Schweitzer Engineering Laborato
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 04 Jan 2013 22:11:19 +0000

Comment # 26 on bug 8089 from 
(In reply to comment #25)
> (In reply to comment #24)
> > (In reply to comment #23)
> > > Created attachment 9769 [details]
> > > Another pass at using wmem
> > > 
> > > Just a stupid typo fix from previous version.
> > 
> > A first quick look at the code looks great!  It all looks much cleaner than
> > before with the glib memory handling.  Which dissector test case did you
> > think looked 'off'?
> 
> I didn't notice a particular one being off, but I don't really know what
> it's supposed to look like - all I did was a quick before-and-after on one
> of the samples you provided. It *looked* fine...

LOL, got it!  I'll check the new code versus all the captures I have and make
sure the output behavior is the same.

Chris

You are receiving this mail because:
  • You are watching all bug changes.