Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7825] Explicitly declare/cast 'unsigned <variable>' as 'unsigned int <variable

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 7 on bug 7825 from Michael Mann

(In reply to comment #6)
> (In reply to comment #1)
> Hi,
> 
> We also use in lot of place 'guint'
> which is also the same as unsigned int...
> 
> And guint is the shortest
> one, maybe not most readable, but I'd vote to do:
> s/unsigned int/guint/g
>
> s/unsigned/guint/g

If that truly means "s/unsigned/guint/g", presumably
> that would be done after also doing

    s/unsigned long/gulong/g

> s/unsigned short/gushort/g
    s/unsigned char/guchar/g

so as not to, for
> example, turn "unsigned char" into "guint char".


I used the regex "unsigned:b(~(int|char|long|short))" to find the "standalone"
unsigned datatypes.  

Does the bug represent the desire to standardize on the glib datatypes or just
to remove the "unsigned" datatype?  The only thing that was preventing me from
closing this was the possibility of adding to checkAPI so we don't have to do
this again.  I wasn't intending to do search/replace of all "native" datatypes
in favor of glib datatypes.

---

      You are receiving this mail because:

• You are watching all bug changes.