Wireshark-bugs: [Wireshark-bugs] [Bug 7936] new dissector for Media Resource Control Protocol Ve
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 02 Jan 2013 19:58:17 +0000

changed bug 7936

What Removed Added
Attachment #9748 is obsolete   1
Attachment #9748 Flags review_for_checkin?  

Comment # 13 on bug 7936 from 
Created attachment 9757 [details]
updated code

I'm using VS2010 for the build. I tried to build in the same revision you did,
46893, and there were no build errors. My guess is that gcc is more restrictive
in unused variables and parameters than VS2010. Looking at the code, variables
are unused, but they are initialized, so it could be a difference significant
for the compiler. I removed the variables and modified code to use the
previously unused parameter.

As for the 'create_dissector_handle' error, I modified code so the
dissect_mrcpv2_tcp() returns void insted of int, same as other dissectors using
the same method. In both cases VS2010 did not throw any warnings or errors, so
could be some difference in the compiler settings.

I fuzzed the changes and they were fine.

You are receiving this mail because:
  • You are watching all bug changes.