Wireshark-bugs: [Wireshark-bugs] [Bug 8019] Extension to wireshark to support PW-Status Message
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 01 Dec 2012 03:47:58 +0000
changed bug 8019
What Removed Added
CC   eapache@gmail.com

Comment # 3 on bug 8019 from 
I've given it a quick look and it seems fine. Just one question off the top of
my head - why are you calling tvb_new_subset_remaining and then passing the new
tvb to dissect_pw_status_tlv? Wouldn't it be easier (and faster) to just pass
the offset and the original tlv?

I'll give it a more thorough review and test tomorrow when I'm actually awake
:)

Cheers,
Evan

You are receiving this mail because:
  • You are watching all bug changes.