Wireshark-bugs: [Wireshark-bugs] [Bug 7852] Wrong casing for Auth-Request-Type enumerations
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 14 Oct 2012 23:47:59 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7852

--- Comment #3 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-10-14 23:47:59 PDT ---
(In reply to comment #2)
> (In reply to comment #1)
> > Seems lik ethis one never madet into SVN inspite of the (+)
> > Committed revision 45499.
> 
> The (+) signifies approval of the fix, which doesn't necessarily mean that it's
> checked in. The bug is only resolved when the matter at hand is resolved, in
> this case the patch is committed.
> The other way around is true also. A bug can be resolved with the attachment
> flag still at (?), which does mean the patch is committed.

Well I don't think we have formalized the use of ?/+/- but if
we were to approve patches by putting (+) and leaving the checking in to some
one else the "search for pending patches" will not find the (+) marked ones
and that would make it easier to forget actually checking it in in my opinion.
Most people who (+) mark bugs have also done the check in in the past.
Just my 2 cents.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.