Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7803] Invalid memory accesses when loading radius captures

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7803

--- Comment #5 from Guy Harris <guy@xxxxxxxxxxxx> 2012-10-06 15:16:39 PDT ---
Here's what I got with my printout code added:

Multiple RADIUS entries for code 19: old Dialback-No, new Login-Callback-Number
Multiple RADIUS entries for code 20: old Dialback-Name, new Framed-Callback-Id
Multiple RADIUS entries for code 2: old Password, new User-Password
Multiple RADIUS entries for code 4: old Client-Id, new NAS-IP-Address
Multiple RADIUS entries for code 5: old Client-Port-Id, new NAS-Port
Multiple RADIUS entries for code 6: old User-Service-Type, new Service-Type
Multiple RADIUS entries for code 8: old Framed-Address, new Framed-IP-Address
Multiple RADIUS entries for code 9: old Framed-Netmask, new Framed-IP-Netmask
Multiple RADIUS entries for code 11: old Framed-Filter-Id, new Filter-Id
Multiple RADIUS entries for code 14: old Login-Host, new Login-IP-Host
Multiple RADIUS entries for code 16: old Login-Port, new Login-TCP-Port
Multiple RADIUS entries for code 18: old Port-Message, new Reply-Message
Multiple RADIUS entries for code 19: old Login-Callback-Number, new
Callback-Number
Multiple RADIUS entries for code 20: old Framed-Callback-Id, new Callback-Id
Multiple RADIUS entries for code 24: old Challenge-State, new State
Multiple RADIUS entries for code 30: old Client-Port-DNIS, new
Called-Station-Id
Multiple RADIUS entries for code 31: old Caller-ID, new Calling-Station-Id
Multiple RADIUS entries for code 5, vendor 3GPP: old Unknown-Attribute-5, new
3GPP-GPRS-Negotiated-QoS-profile
Multiple RADIUS entries for code 12, vendor 3GPP: old Unknown-Attribute-12, new
3GPP-Selection-Mode
Multiple RADIUS entries for code 22, vendor 3GPP: old Unknown-Attribute-22, new
3GPP-User-Location-Info
Multiple RADIUS entries for code 74, vendor 3GPP2: old Unknown-Attribute-74,
new 3GPP2-Service-Option-Profile
Multiple RADIUS entries for code 131, vendor 3GPP2: old Unknown-Attribute-131,
new 3GPP2-Authorized-Flow-Profile-IDs
Multiple RADIUS entries for code 17, vendor Alcatel-Lucent-Service-Router: old
Alc-Retail-Serv-Id, new Alc-Retail-Serv-Id
Multiple RADIUS entries for code 1, vendor Alvarion: old Alvariaon-VSA-1, new
Breezecom-Attr1
Multiple RADIUS entries for code 2, vendor Alvarion: old Alvariaon-VSA-2, new
Breezecom-Attr2
Multiple RADIUS entries for code 3, vendor Alvarion: old Alvariaon-VSA-3, new
Breezecom-Attr3
Multiple RADIUS entries for code 4, vendor Alvarion: old Alvariaon-VSA-4, new
Breezecom-Attr4
Multiple RADIUS entries for code 5, vendor Alvarion: old Alvariaon-VSA-5, new
Breezecom-Attr5
Multiple RADIUS entries for code 6, vendor Alvarion: old Alvariaon-VSA-6, new
Breezecom-Attr6
Multiple RADIUS entries for code 7, vendor Alvarion: old Alvariaon-VSA-7, new
Breezecom-Attr7
Multiple RADIUS entries for code 8, vendor Alvarion: old Alvariaon-VSA-8, new
Breezecom-Attr8
Multiple RADIUS entries for code 9, vendor Alvarion: old Alvariaon-VSA-9, new
Breezecom-Attr9
Multiple RADIUS entries for code 10, vendor Alvarion: old Alvariaon-VSA-10, new
Breezecom-Attr10
Multiple RADIUS entries for code 11, vendor Alvarion: old Alvariaon-VSA-11, new
Breezecom-Attr11
Multiple RADIUS entries for code 1, vendor CableLabs: old Unknown-Attribute-1,
new CableLabs-Event-Message
Multiple RADIUS entries for code 11, vendor CableLabs: old
Unknown-Attribute-11, new CableLabs-Call-Termination-Cause
Multiple RADIUS entries for code 13, vendor CableLabs: old
Unknown-Attribute-13, new CableLabs-Related-Call-Billing-Crl-ID
Multiple RADIUS entries for code 24, vendor CableLabs: old
Unknown-Attribute-24, new CableLabs-Trunk-Group-ID
Multiple RADIUS entries for code 32, vendor CableLabs: old
Unknown-Attribute-32, new CableLabs-QoS-Descriptor
Multiple RADIUS entries for code 38, vendor CableLabs: old
Unknown-Attribute-38, new CableLabs-Time-Adjustment
Multiple RADIUS entries for code 43, vendor CableLabs: old
Unknown-Attribute-43, new CableLabs-Redirected-From-Info
Multiple RADIUS entries for code 44, vendor CableLabs: old
Unknown-Attribute-44, new CableLabs-Electronic-Surveillance-Ind
Multiple RADIUS entries for code 47, vendor CableLabs: old
Unknown-Attribute-47, new CableLabs-El-Surveillance-DF-Security
Multiple RADIUS entries for code 54, vendor CableLabs: old
Unknown-Attribute-54, new CableLabs-Terminal-Display-Info
Multiple RADIUS entries for code 81, vendor Ericsson: old
Ericsson-ViG-Time-stamp-UTC, new Ericsson-ViG-Time-stamp-UTC
Multiple RADIUS entries for code 109, vendor Ericsson: old
Ericsson-ViG-Test-Call-Indicator, new Ericsson-ViG-Test-Call-Indicator
Multiple RADIUS entries for code 40, vendor HP: old
HP-Port-Priority-Regeneration-Table, new HP-Cos
Multiple RADIUS entries for code 61, vendor HP: old HP-Ip-Filter-Raw, new
HP-Nas-Filter-Rule
Multiple RADIUS entries for code 8, vendor Microsoft: old
MS-MPPE-Encryption-Type, new MS-MPPE-Encryption-Types
Multiple RADIUS entries for code 1, vendor Redback: old Client_DNS_Pri, new
Client-DNS-Pri
Multiple RADIUS entries for code 2, vendor Redback: old Client_DNS_Sec, new
Client-DNS-Sec
Multiple RADIUS entries for code 3, vendor Redback: old DHCP_Max_Leases, new
DHCP-Max-Leases
Multiple RADIUS entries for code 4, vendor Redback: old Context_Name, new
Context-Name
Multiple RADIUS entries for code 5, vendor Redback: old Bridge_Group, new
Bridge-Group
Multiple RADIUS entries for code 6, vendor Redback: old BG_Aging_Time, new
BG-Aging-Time
Multiple RADIUS entries for code 7, vendor Redback: old BG_Path_Cost, new
BG-Path-Cost
Multiple RADIUS entries for code 8, vendor Redback: old BG_Span_Dis, new
BG-Span-Dis
Multiple RADIUS entries for code 9, vendor Redback: old BG_Trans_BPDU, new
BG-Trans-BPDU
Multiple RADIUS entries for code 10, vendor Redback: old Rate_Limit_Rate, new
Rate-Limit-Rate
Multiple RADIUS entries for code 11, vendor Redback: old Rate_Limit_Burst, new
Rate-Limit-Burst
Multiple RADIUS entries for code 12, vendor Redback: old Police_Rate, new
Police-Rate
Multiple RADIUS entries for code 13, vendor Redback: old Police_Burst, new
Police-Burst
Multiple RADIUS entries for code 14, vendor Redback: old Source_Validation, new
Source-Validation
Multiple RADIUS entries for code 15, vendor Redback: old Tunnel_Domain, new
Tunnel-Domain
Multiple RADIUS entries for code 16, vendor Redback: old Tunnel_Local_Name, new
Tunnel-Local-Name
Multiple RADIUS entries for code 17, vendor Redback: old Tunnel_Remote_Name,
new Tunnel-Remote-Name
Multiple RADIUS entries for code 18, vendor Redback: old Tunnel_Function, new
Tunnel-Function
Multiple RADIUS entries for code 19, vendor Redback: old Tunnel-Flow-Control,
new Tunnel-Flow-Control
Multiple RADIUS entries for code 20, vendor Redback: old Tunnel-Static, new
Tunnel-Static
Multiple RADIUS entries for code 21, vendor Redback: old Tunnel_Max_Sessions,
new Tunnel-Max-Sessions
Multiple RADIUS entries for code 22, vendor Redback: old Tunnel_Max_Tunnels,
new Tunnel-Max-Tunnels
Multiple RADIUS entries for code 23, vendor Redback: old Tunnel_Session_Auth,
new Tunnel-Session-Auth
Multiple RADIUS entries for code 24, vendor Redback: old Tunnel_Window, new
Tunnel-Window
Multiple RADIUS entries for code 25, vendor Redback: old Tunnel_Retransmit, new
Tunnel-Retransmit
Multiple RADIUS entries for code 26, vendor Redback: old Tunnel_Cmd_Timeout,
new Tunnel-Cmd-Timeout
Multiple RADIUS entries for code 27, vendor Redback: old PPPOE_URL, new
PPPOE-URL
Multiple RADIUS entries for code 28, vendor Redback: old PPPOE_MOTM, new
PPPOE-MOTM
Multiple RADIUS entries for code 29, vendor Redback: old Tunnel_Group, new
Tunnel-Group
Multiple RADIUS entries for code 30, vendor Redback: old Tunnel_Context, new
Tunnel-Context
Multiple RADIUS entries for code 31, vendor Redback: old Tunnel_Algorithm, new
Tunnel-Algorithm
Multiple RADIUS entries for code 32, vendor Redback: old Tunnel_Deadtime, new
Tunnel-Deadtime
Multiple RADIUS entries for code 33, vendor Redback: old Mcast_Send, new
Mcast-Send
Multiple RADIUS entries for code 34, vendor Redback: old Mcast_Receive, new
Mcast-Receive
Multiple RADIUS entries for code 35, vendor Redback: old Mcast_MaxGroups, new
Mcast-MaxGroups
Multiple RADIUS entries for code 36, vendor Redback: old Ip_Address_Pool_Name,
new Ip-Address-Pool-Name
Multiple RADIUS entries for code 37, vendor Redback: old Tunnel_DNIS, new
Tunnel-DNIS
Multiple RADIUS entries for code 38, vendor Redback: old Medium_Type, new
Medium-Type
Multiple RADIUS entries for code 39, vendor Redback: old
PVC_Encapsulation_Type, new PVC-Encapsulation-Type
Multiple RADIUS entries for code 40, vendor Redback: old PVC_Profile_Name, new
PVC-Profile-Name
Multiple RADIUS entries for code 41, vendor Redback: old PVC_Circuit_Padding,
new PVC-Circuit-Padding
Multiple RADIUS entries for code 42, vendor Redback: old Bind_Type, new
Bind-Type
Multiple RADIUS entries for code 43, vendor Redback: old Bind_Auth_Protocol,
new Bind-Auth-Protocol
Multiple RADIUS entries for code 44, vendor Redback: old
Bind_Auth_Max_Sessions, new Bind-Auth-Max-Sessions
Multiple RADIUS entries for code 45, vendor Redback: old Bind_Bypass_Bypass,
new Bind-Bypass-Bypass
Multiple RADIUS entries for code 46, vendor Redback: old Bind_Auth_Context, new
Bind-Auth-Context
Multiple RADIUS entries for code 47, vendor Redback: old Bind_Auth_Service_Grp,
new Bind-Auth-Service-Grp
Multiple RADIUS entries for code 48, vendor Redback: old Bind_Bypass_Context,
new Bind-Bypass-Context
Multiple RADIUS entries for code 49, vendor Redback: old Bind_Int_Context, new
Bind-Int-Context
Multiple RADIUS entries for code 50, vendor Redback: old Bind_Tun_Context, new
Bind-Tun-Context
Multiple RADIUS entries for code 51, vendor Redback: old Bind_Ses_Context, new
Bind-Ses-Context
Multiple RADIUS entries for code 52, vendor Redback: old Bind_Dot1q_Slot, new
Bind-Dot1q-Slot
Multiple RADIUS entries for code 53, vendor Redback: old Bind_Dot1q_Port, new
Bind-Dot1q-Port
Multiple RADIUS entries for code 54, vendor Redback: old
Bind_Dot1q_Vlan_Tag_Id, new Bind-Dot1q-Vlan-Tag-Id
Multiple RADIUS entries for code 55, vendor Redback: old
Bind_Int_Interface_Name, new Bind-Int-Interface-Name
Multiple RADIUS entries for code 56, vendor Redback: old Bind_L2TP_Tunnel_Name,
new Bind-L2TP-Tunnel-Name
Multiple RADIUS entries for code 57, vendor Redback: old
Bind_L2TP_Flow_Control, new Bind-L2TP-Flow-Control
Multiple RADIUS entries for code 58, vendor Redback: old
Bind_Sub_User_At_Context, new Bind-Sub-User-At-Context
Multiple RADIUS entries for code 59, vendor Redback: old Bind_Sub_Password, new
Bind-Sub-Password
Multiple RADIUS entries for code 60, vendor Redback: old Ip_Host_Addr, new
Ip-Host-Addr
Multiple RADIUS entries for code 61, vendor Redback: old IP_TOS_Field, new
IP-TOS-Field
Multiple RADIUS entries for code 62, vendor Redback: old NAS_Real_Port, new
NAS-Real-Port
Multiple RADIUS entries for code 63, vendor Redback: old
Tunnel_Session_Auth_Ctx, new Tunnel-Session-Auth-Ctx
Multiple RADIUS entries for code 64, vendor Redback: old
Tunnel_Session_Auth_Service_Grp, new Tunnel-Session-Auth-Service-Grp
Multiple RADIUS entries for code 65, vendor Redback: old
Tunnel_Rate_Limit_Rate, new Tunnel-Rate-Limit-Rate
Multiple RADIUS entries for code 66, vendor Redback: old
Tunnel_Rate_Limit_Burst, new Tunnel-Rate-Limit-Burst
Multiple RADIUS entries for code 67, vendor Redback: old Tunnel_Police_Rate,
new Tunnel-Police-Rate
Multiple RADIUS entries for code 68, vendor Redback: old Tunnel_Police_Burst,
new Tunnel-Police-Burst
Multiple RADIUS entries for code 69, vendor Redback: old
Tunnel_L2F_Second_Password, new Tunnel-L2F-Second-Password
Multiple RADIUS entries for code 70, vendor Redback: old ACL-Definition, new
ACL-Definition
Multiple RADIUS entries for code 71, vendor Redback: old PPPoE-IP-Route-Add,
new PPPoE-IP-Route-Add
Multiple RADIUS entries for code 72, vendor Redback: old TTY_Level_Max, new
TTY-Level-Max
Multiple RADIUS entries for code 73, vendor Redback: old TTY_Level_Start, new
TTY-Level-Start
Multiple RADIUS entries for code 78, vendor Redback: old Tunnel-Client-VPN, new
Tunnel-Client-VPN
Multiple RADIUS entries for code 79, vendor Redback: old Tunnel-Server-VPN, new
Tunnel-Server-VPN
Multiple RADIUS entries for code 84, vendor Redback: old PPP-Compression, new
PPP-Compression
Multiple RADIUS entries for code 85, vendor Redback: old Tunnel-Hello-Timer,
new Tunnel-Hello-Timer
Multiple RADIUS entries for code 86, vendor Redback: old Redback-Reason, new
Redback-Reason
Multiple RADIUS entries for code 87, vendor Redback: old Qos-Policy-Policing,
new Qos-Policing-Profile-Name
Multiple RADIUS entries for code 88, vendor Redback: old Qos-Policy-Metering,
new Qos-Metering-Profile-Name
Multiple RADIUS entries for code 89, vendor Redback: old Qos-Policy-Queuing,
new Qos-Policy-Queuing
Multiple RADIUS entries for code 90, vendor Redback: old Igmp-Service-Profile,
new IGMP-Service-Profile-Name
Multiple RADIUS entries for code 91, vendor Redback: old Sub-Profile-Name, new
Subscriber-Profile-Name
Multiple RADIUS entries for code 92, vendor Redback: old Forward-Policy, new
Forward-Policy
Multiple RADIUS entries for code 93, vendor Redback: old Remote-Port, new
Remote-Port
Multiple RADIUS entries for code 94, vendor Redback: old Reauth-String, new
Reauth
Multiple RADIUS entries for code 95, vendor Redback: old Reauth-More, new
Reauth-More
Multiple RADIUS entries for code 96, vendor Redback: old Agent-Remote-Id, new
Agent-Remote-Id
Multiple RADIUS entries for code 97, vendor Redback: old Agent-Circuit-Id, new
Agent-Circuit-Id
Multiple RADIUS entries for code 98, vendor Redback: old Platform-Type, new
Platform-Type
Multiple RADIUS entries for code 99, vendor Redback: old RB-Client-NBNS-Pri,
new Client-NBNS-Pri
Multiple RADIUS entries for code 100, vendor Redback: old RB-Client-NBNS-Sec,
new Client-NBNS-Sec
Multiple RADIUS entries for code 101, vendor Redback: old Shaping-Profile-Name,
new Shaping-Profile-Name
Multiple RADIUS entries for code 103, vendor Redback: old Bridge-Profile, new
BG-Cct-Addr-Max
Multiple RADIUS entries for code 104, vendor Redback: old IP-Interface, new
IP-Interface-Name
Multiple RADIUS entries for code 105, vendor Redback: old NAT-Policy-Name, new
NAT-Policy-Name
Multiple RADIUS entries for code 106, vendor Redback: old RB-NPM-Service-Id,
new RB-NPM-Service-Id
Multiple RADIUS entries for code 107, vendor Redback: old
HTTP-Redirect-Profile-Name, new HTTP-Redirect-Profile-Name
Multiple RADIUS entries for code 108, vendor Redback: old Bind-Auto-Sub-User,
new Bind-Auto-Sub-User
Multiple RADIUS entries for code 109, vendor Redback: old
Bind-Auto-Sub-Context, new Bind-Auto-Sub-Context
Multiple RADIUS entries for code 110, vendor Redback: old
Bind-Auto-Sub-Password, new Bind-Auto-Sub-Password
Multiple RADIUS entries for code 111, vendor Redback: old
Circuit-Protocol-Encap, new Circuit-Protocol-Encap
Multiple RADIUS entries for code 112, vendor Redback: old OS-Version, new
OS-Version
Multiple RADIUS entries for code 113, vendor Redback: old
Session-Traffic-Limit, new Session-Traffic-Limit
Multiple RADIUS entries for code 114, vendor Redback: old QOS-Reference, new
QOS-Reference
Multiple RADIUS entries for code 125, vendor Redback: old DHCP-Vendor-Class-ID,
new DHCP-Vendor-Class-ID
Multiple RADIUS entries for code 126, vendor Redback: old Qos-Rate, new
Qos-Rate
Multiple RADIUS entries for code 127, vendor Redback: old
DHCP-Vendor-Encap-Option, new DHCP-Vendor-Encap-Option
Multiple RADIUS entries for code 128, vendor Redback: old Acct_Input_Octets_64,
new Acct-Input-Octets-64
Multiple RADIUS entries for code 129, vendor Redback: old
Acct_Output_Octets_64, new Acct-Output-Octets-64
Multiple RADIUS entries for code 130, vendor Redback: old
Acct_Input_Packets_64, new Acct-Input-Packets-64
Multiple RADIUS entries for code 131, vendor Redback: old
Acct_Output_Packets_64, new Acct-Output-Packets-64
Multiple RADIUS entries for code 132, vendor Redback: old Assigned_IP_Address,
new Assigned-IP-Address
Multiple RADIUS entries for code 133, vendor Redback: old Acct_Mcast_In_Octets,
new Acct-Mcast-In-Octets-64
Multiple RADIUS entries for code 134, vendor Redback: old
Acct_Mcast_Out_Octets, new Acct-Mcast-Out-Octets-64
Multiple RADIUS entries for code 135, vendor Redback: old
Acct_Mcast_In_Packets, new Acct-Mcast-In-Packets-64
Multiple RADIUS entries for code 136, vendor Redback: old
Acct_Mcast_Out_Packets, new Acct-Mcast-Out-Packets-64
Multiple RADIUS entries for code 137, vendor Redback: old LAC_Port, new
LAC-Port
Multiple RADIUS entries for code 138, vendor Redback: old LAC_Real_Port, new
LAC-Real-Port
Multiple RADIUS entries for code 139, vendor Redback: old LAC_Port_Type, new
LAC-Port-Type
Multiple RADIUS entries for code 140, vendor Redback: old LAC_Real_Port_Type,
new LAC-Real-Port-Type
Multiple RADIUS entries for code 141, vendor Redback: old Acct_Dyn_Ac_Ent, new
Acct-Dyn-Ac-Ent
Multiple RADIUS entries for code 142, vendor Redback: old Session_Error_Code,
new Session-Error-Code
Multiple RADIUS entries for code 143, vendor Redback: old Session_Error_Msg,
new Session-Error-Msg
Multiple RADIUS entries for code 189, vendor Redback: old Flow-FAC-Profile, new
Flow-FAC-Profile
Multiple RADIUS entries for code 1, vendor SonicWall: old
SS3-Firewall-User-Privilege, new SonicWall-User-Privilege
Multiple RADIUS entries for code 206, vendor Starent: old SNA-Input-Gigawords,
new SN-WiMAX-Auth-Only
Multiple RADIUS entries for code 126: old Operator-Name, new Multi-Link-Flag

Some of those may be due to dictionary.compat, which provides additional names
for given codes, for compatibility; those may be useful if you're reading files
that have RADIUS entries by name and need to translate them to codes, but I
think we're translating codes to names, so they may not be necessary. 
(However, if I remove radius/dictionary.compat, Wireshark crashes with a memory
corruption error, that I'm trying to track down; Evan's change doesn't fix that
- I'm not sure what's causing the trashing; it's happening in a free call.)

Some others are duplicates within dictionary.redback; there's a comment there:

#
#       Redback Vendor Specific Extensions
#
#       The first set here uses '_' as the separator, as Redback has changed
#       their documentation to use '-' vs. '_'.  The older '_' style entries
#       are listed first so that they will still be accepted,
#       yet not preferred.

so this is probably another case of "useful for translating from names to
codes, useless for translating codes to names".

  Multiple RADIUS entries for code 126: old Operator-Name, new Multi-Link-Flag

looks like a case of a code being reused - Operator-Name is from
dictionary.rfc5580, i.e. "defined by RFC 5580", and Multi-Link-Flag is from
dictionary.usr:

#               Taken from the dictionary included with the USR RADIUS server,
#               and adjusted a bit.

so maybe U.S. Robotics used that code but didn't register it in any way to keep
RFC 5580 from reusing it.  That may be one of those "needs a preference" cases.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.