Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 7773] Explicitly assign pointers released by g_free() to NULL

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7773

--- Comment #2 from Bill Parker <wp02855@xxxxxxxxx> 2012-09-30 11:33:19 PDT ---
(In reply to comment #1)
> (In reply to comment #0)
> > The files included in this tarball are patchfiles generated by 'diff -u' which
> > explicitly set pointer variables released by a call to g_free() to NULL.
> > 
> > In most contexts, when a pointer is released via free, should not the following
> > occur?
> > [...]
> >     free(p);
> >     p = NULL;
> > 
> > Or am I mistaken in this issue?
> 
> It might be issue if you reuse variable several times, or use it as global
> variable, but if you end variable scope with g_free, like:
> 
>      g_free(decoded_param);
> +    decoded_param = NULL;
>      return FALSE;
> 
> I don't see much sense to explicit set it to NULL, do you?

Well, in some areas of the code, file u3.c for example, this is done
explicitly, but in the files I submitted it isn't (might be splitting hairs
here), but shouldn't it be consistent throughout the code?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.