Wireshark-bugs: [Wireshark-bugs] [Bug 7772] [PATCH] dissect only the number of active subcarrier
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 30 Sep 2012 09:36:51 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7772

Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darkjames-ws@xxxxxxxxxxxx

--- Comment #4 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-09-30 09:36:50 PDT ---
(In reply to comment #1)
> Hi Florian,
> 
> +      for (i = 0; i < num_act_carriers / 2; i++) {
> May be add a check to verify num_act_carriers is different of 0 ?

Why?

I'd rather add checks when num_act_carriers is odd, 

if (num_act_carriers & 1) {
  /* add_expert_info? */ 
}

or is it normal to have num_act_carriers odd?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.