Wireshark-bugs: [Wireshark-bugs] [Bug 7770] Failure to check for return values after calls to ca
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 29 Sep 2012 12:44:18 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7770

--- Comment #7 from Guy Harris <guy@xxxxxxxxxxxx> 2012-09-29 12:44:18 PDT ---
(In reply to comment #5)
> Hmmmm, valid point, but there are still some points in lemon.c which fail to
> properly check the return value from calloc() (this is in the patch file which
> I attached to the bug report when generated).

Note that when a patch file is attached, it should be marked as such, and
should also have review_for_checkin set to ? if it's ready to be reviewed.

> Please review and let me know if the checks should be added to the code/file in
> question (this might border on paranoia mode, but having things go KABOOM due
> to lack of sanity checking is just asking for trouble, IMO).

Done.  Printing an error message and exiting is better than crashing with
SIGSEGV/SIGBUS/whatever it's called on Windows when you dereference a null
pointer.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.