Wireshark-bugs: [Wireshark-bugs] [Bug 7749] TRILL: RBridge Channel Support in wireshark
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 25 Sep 2012 14:15:07 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7749

Pascal Quantin <pascal.quantin@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pascal.quantin@xxxxxxxxx

--- Comment #2 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2012-09-25 14:15:06 PDT ---
Hi Rahul,

a few comments:
- please add a header that complies with the example given in README.developer
- change protocol_strings from range_string to value_string, there is no reason
to use a range here
- replace flag_sl_strings, flag_mh_strings and flag_na_strings from
range_string to true_false_string, there is no reason to use a range here (and
change the type from FT_UINT16 to FT_BOOLEAN)
- filter names (currently starting with rbridge_ch.) should match PROTOABBREV
(currently set to rbridge_channel)
- where does the ETHERTYPE_CHANNEL 0x22F5 comes from? It's not referenced yet
in IEEE
- could you attach the sample pcap you are referring to in the bug description?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.