https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7716
--- Comment #13 from Daniel <danielh@xxxxxxxxxxxx> 2012-09-19 00:43:45 PDT ---
Hi Michael,
New patch is attached, please see my comment below:
>1. Some of the new proto_tree_add_item() calls look like they were just
> search/replaced from proto_tree_add_[uint|boolean].
Fixed
> 2. Some of the boolean values are from a 16-bit value, yet are of "size" 8 in
> the hf array.
Fixed
> 3. Some of the TFS enumerations could be used to make the boolean field values
> clearer (like tfs_present_not_present)
Fixed
> 4. If proto_tree_add_uint_format() isn't actually doing any formatting
> different than the hf array value, it's much cleaner to still use
> proto_tree_add_item(), even if you've retrieved the value already with a
> tvb_get_guint8 (or similar), just because it's nice to have all of the
> "display" values in a single place - the hf array. Using
> proto_tree_add_uint_format() requires hunting through the dissector if a field
> name needs to be changed.
I replaced all proto_tree_add_format functions with proto_tree_add_uint. I have
to use proto_tree_add_uint because I retrieve value with tvb_get_guint8. Now
everything is in one place - hf array.
> 5. checkAPIs.pl yielded the following output:
> Error: the blurb for hf_radiotap_vht_ldpc_extra ("radiotap.vht.ldpc_extra")
> matches the field name in
> c:/wireshark/epan/dissectors/packet-ieee80211-radiotap.c
> Error: the blurb for hf_radiotap_vht_bf ("radiotap.vht.beamformed") matches the
> field name in c:/wireshark/epan/dissectors/packet-ieee80211-radiotap.c
> Error: the blurb for hf_radiotap_vht_bw ("radiotap.vht.bw") matches the field
> name in c:/wireshark/epan/dissectors/packet-ieee80211-radiotap.c
> Error: the blurb for hf_radiotap_vht_gid ("radiotap.vht.gid") matches the field
> name in c:/wireshark/epan/dissectors/packet-ieee80211-radiotap.c
> Error: the blurb for hf_radiotap_vht_p_aid ("radiotap.paid") matches the field
> name in c:/wireshark/epan/dissectors/packet-ieee80211-radiotap.c
> Error: Found C++ style comments in
> c:/wireshark/epan/dissectors/packet-ieee80211-radiotap.c
>
>
> (the first few should just replace the blurb with NULL if field name == blurb).
> In general I didn't think most of the blurbs added value outside of the field
> name and could be switched to NULL.
Fixed. I left only blurbs that I think make sense.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
